Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit the need for WANT_HAVEs and cut them off in case its not #3632

Closed
Wondertan opened this issue Aug 7, 2024 · 4 comments
Closed

Audit the need for WANT_HAVEs and cut them off in case its not #3632

Wondertan opened this issue Aug 7, 2024 · 4 comments
Labels
shwap

Comments

@Wondertan
Copy link
Member

No description provided.

@Wondertan Wondertan mentioned this issue Aug 7, 2024
Open
58 tasks
@Wondertan
Copy link
Member Author

Made this issue by accident, it doesn't need to be a standalone issue yet, but does not hurt to keep it

@renaynay
Copy link
Member

More information in #3630

@renaynay renaynay closed this as not planned Won't fix, can't repro, duplicate, stale Aug 15, 2024
@Wondertan Wondertan reopened this Aug 15, 2024
@Wondertan
Copy link
Member Author

Wondertan commented Aug 15, 2024 •
edited
Loading

That's unrelated to #3630 and comes from #3513

@Wondertan
Copy link
Member Author

Bitswap sends WANT_BLOCK for each sample to one peer and WANT_HAVE to other peers in the session as a back-up in case WANT_BLOCK is unsuccefull. The original worry behind this issue was that WANT_HAVE adds a roundtrip, which is not the case, so we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
shwap
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Wondertan @renaynay