Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tagged releases for Celestia dependencies #606

Closed
adlerjohn opened this issue Apr 11, 2022 · 3 comments · Fixed by #607
Closed

Use tagged releases for Celestia dependencies #606

adlerjohn opened this issue Apr 11, 2022 · 3 comments · Fixed by #607
Labels
kind:deps Pull requests that update a dependency file

Comments

@adlerjohn
Copy link
Member

Implementation ideas

No response
@adlerjohn adlerjohn added the kind:deps Pull requests that update a dependency file label Apr 11, 2022
@adlerjohn adlerjohn moved this to TODO in Celestia Node Apr 11, 2022
@liamsi
Copy link
Member

liamsi commented Apr 11, 2022

currently:

celestia-node/go.mod

Line 9 in 16dba97

github.com/celestiaorg/celestia-app v0.0.2-0.20220214170311-cfe3ecf30837

@liamsi
Copy link
Member

liamsi commented Apr 11, 2022

Also, it would be good if a linter could automatically check for this. So we won't miss these again. The line above was introduce in #420 and approved by 3 reviewers...

@Wondertan
Copy link
Member

True, we should've caught this

@liamsi liamsi mentioned this issue Apr 11, 2022
Merged
@adlerjohn adlerjohn linked a pull request Apr 11, 2022 that will close this issue
fix go.mod to use tagged releases #607
Merged
Repository owner moved this from TODO to Done in Celestia Node Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind:deps Pull requests that update a dependency file
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix go.mod to use tagged releases celestiaorg/celestia-node
3 participants
@adlerjohn @liamsi @Wondertan