Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement remaining transaction type proxies in coreAccessor #946

Closed
3 tasks
Tracked by #568
renaynay opened this issue Jul 26, 2022 · 3 comments · Fixed by #984
Closed
3 tasks
Tracked by #568

Implement remaining transaction type proxies in coreAccessor #946

renaynay opened this issue Jul 26, 2022 · 3 comments · Fixed by #984
Assignees
Labels
area:rpc area:state Related to fetching state and state execution

Comments

@renaynay
Copy link
Member

renaynay commented Jul 26, 2022

  • Implement each transaction type proxy inside of core_access.go
  • expose these methods via higher level Accessor interface and have Service proxy to the accessor's impl of them
  • expose via RPC
@renaynay renaynay added the area:state Related to fetching state and state execution label Jul 26, 2022
@renaynay renaynay moved this to TODO in Celestia Node Jul 26, 2022
@distractedm1nd
Copy link
Collaborator

@distractedm1nd
Copy link
Collaborator

distractedm1nd commented Aug 3, 2022

So, from my understanding, the transaction types we need to proxy are sdk.Msg's which are defined in the cosmos-sdk modules. For example, bankypes.NewMsgSend for our ca.Transfer.

Is this correct @renaynay ? I cannot find any comprehensive list of all Msg types supported by all standard modules, and it looks like we don't need all of them (unsure though). So I would start with the staking types first as you linked me. Any other ones, or is that all for now?

@distractedm1nd distractedm1nd moved this from TODO to In Progress in Celestia Node Aug 3, 2022
@renaynay
Copy link
Member Author

renaynay commented Aug 3, 2022

We need:

TypeMsgUndelegate                = "begin_unbonding"
TypeMsgCancelUnbondingDelegation = "cancel_unbond"
TypeMsgDelegate                  = "delegate"
TypeMsgBeginRedelegate           = "begin_redelegate"

@renaynay renaynay moved this from In Progress to In Review in Celestia Node Aug 5, 2022
Repository owner moved this from In Review to Done in Celestia Node Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rpc area:state Related to fetching state and state execution
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants