Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing or moving the loadEnvVars from New to somewhere else #457

Closed
Tracked by #488
mojtaba-esk opened this issue Jun 25, 2024 · 0 comments · Fixed by #503
Closed
Tracked by #488

Consider removing or moving the loadEnvVars from New to somewhere else #457

mojtaba-esk opened this issue Jun 25, 2024 · 0 comments · Fixed by #503
Labels
knuu refactor Refactoring
Milestone

Comments

@mojtaba-esk
Copy link
Member

loading env var is not the main task of knuu as with the recent refactors, it is configurable via its New function.
So this issue suggests that to remove it from knuu.New and allow users to load it when they need for their purpose and then configure the knuu the way that they need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
knuu refactor Refactoring
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants