Correctly handle the abort intrinsic (rust-lang#151)

Author: danielsn

compiler/rustc_codegen_llvm/src/gotoc/hooks.rs

@@ -221,15 +221,19 @@ impl<'tcx> GotocHook<'tcx> for Intrinsic {
         span: Option<Span>,
     ) -> Stmt {
         let loc = tcx.codegen_span_option2(span);
-        let p = assign_to.unwrap();
-        let target = target.unwrap();
-        Stmt::block(
-            vec![
-                tcx.codegen_intrinsic(instance, fargs, &p, span),
-                Stmt::goto(tcx.find_label(&target), loc.clone()),
-            ],
-            loc,
-        )
+        if (tcx.symbol_name(instance) == "abort") {
+            Stmt::assert_false("abort intrinsic reached", loc)
+        } else {
+            let p = assign_to.unwrap();
+            let target = target.unwrap();
+            Stmt::block(
+                vec![
+                    tcx.codegen_intrinsic(instance, fargs, &p, span),
+                    Stmt::goto(tcx.find_label(&target), loc.clone()),
+                ],
+                loc,
+            )
+        }
     }
 }
 

rust-tests/cbmc-reg/Intrinsics/abort_fail.rs

@@ -0,0 +1,7 @@
+// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+// SPDX-License-Identifier: Apache-2.0 OR MIT
+#![feature(core_intrinsics)]
+use std::intrinsics;
+fn main() {
+    intrinsics::abort();
+}