Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update identity SDK to abort hanging Promises #10083

Closed
isabellewei opened this issue Dec 19, 2022 · 0 comments · Fixed by #10131
Closed

Update identity SDK to abort hanging Promises #10083

isabellewei opened this issue Dec 19, 2022 · 0 comments · Fixed by #10131
Assignees
@alecps
Labels
ASv2 adoption Component: Identity Identity-Q1-2023

Comments

@isabellewei
Copy link
Contributor

isabellewei commented Dec 19, 2022 •
edited
Loading

accept optional AbortController

refer to https://celo-org.slack.com/archives/C02TX7BGJHG/p1671474844544509
@isabellewei isabellewei converted this from a draft issue Dec 19, 2022
@alecps alecps mentioned this issue Dec 21, 2022
Merged
@alecps alecps moved this from 🌟 New Issues to 🪜 This Milestone in 🔖 Identity - Team Jan 5, 2023
@alecps alecps changed the title Update ODIS SDK to abort hanging Promises Update identity SDK to abort hanging Promises Jan 11, 2023
@alecps alecps self-assigned this Jan 11, 2023
@alecps alecps moved this from 🪜 This Milestone to 🌳 Sprint Backlog in 🔖 Identity - Team Jan 12, 2023
@alecps alecps moved this from 🌳 Sprint Backlog to 🏃‍♀️ In Progress in 🔖 Identity - Team Jan 12, 2023
@alecps alecps mentioned this issue Jan 26, 2023
Merged
@alecps alecps moved this from 🏃‍♀️ In Progress to 🙏 Review/QA in 🔖 Identity - Team Jan 26, 2023
@github-project-automation github-project-automation bot moved this from 🙏 Review/QA to ✅ Closed in 🔖 Identity - Team Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alecps alecps

Labels
ASv2 adoption Component: Identity Identity-Q1-2023
Projects
🔖 Identity - Team
Status: ✅ Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds timeout and docstrings to identity SDK celo-org/celo-monorepo
2 participants
@isabellewei @alecps