-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GCP 127 [DRAFT - do not merge] #412
Conversation
should we close this PR @pahor167 ? |
@@ -0,0 +1,25 @@ | |||
[ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing the transfer from the reserve, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really since we are specifying range of stCelo<->Celo, but the pool already exists (with rather incorrect prices) and Uniswap doesn't allow us to create LP with 1:1 but rather it allows us for this specific range only to add stCelo
"value": "10000000000000000000000000" | ||
}, | ||
{ | ||
"address": "0xC668583dcbDc9ae6FA3CE46462758188adfdfC24", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we also need the approve for CELO?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the comment above
{ | ||
"address": "0x3d79edaabc0eab6f08ed885c05fc0b014290d95a", | ||
"function": "mint", | ||
"args": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you try to dry-run this to see if tx revert? could be done in a fork.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I did
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
Depositing 10 million CELO into the stCELO protocol. This step involves converting CELO into stCELO, a staked version of CELO that earns staking rewards and contributes to the security of the network. | ||
|
||
Deploying the resulting stCELO into the Uniswap V3 liquidity pool. This action aims to improve liquidity on the decentralized exchange, facilitating smoother transactions and potentially reducing the impact of large trades on CELO's price. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need the verification instructions, specially for the uniswap v3 call.
"address": "0x3d79edaabc0eab6f08ed885c05fc0b014290d95a", | ||
"function": "mint", | ||
"args": [ | ||
"{\"token0\": \"0x471EcE3750Da237f93B8E339c536989b8978a438\",\"token1\": \"0xC668583dcbDc9ae6FA3CE46462758188adfdfC24\",\"fee\": 100,\"tickLower\": -1764,\"tickUpper\": -631,\"amount0Desired\": \"0\",\"amount1Desired\": \"9353810000000000000000000\",\"amount0Min\": \"0\",\"amount1Min\": \"9353810000000000000000000\",\"recipient\": \"0xD533Ca259b330c7A88f74E000a3FaEa2d63B7972\",\"deadline\": 1728991576}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a source for the math: https://uniswapv3book.com/milestone_1/calculating-liquidity.html
No description provided.