Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Update for RainbowKit v2 #84

Closed
jmrossy opened this issue Jan 13, 2024 · 7 comments
Closed

Update for RainbowKit v2 #84

jmrossy opened this issue Jan 13, 2024 · 7 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@jmrossy
Copy link

jmrossy commented Jan 13, 2024

Wagmi + Viem v2 are live. Rainbowkit has published a v2 beta to match it.

Relevant docs:
https://beta.rainbowkit.com/guides/rainbowkit-wagmi-v2
https://viem.sh/docs/migration-guide#2xx-breaking-changes
https://wagmi.sh/react/guides/migrate-from-v1-to-v2

@jmrossy
Copy link
Author

jmrossy commented Jan 13, 2024

Alternatively, it may be better to just get the wallets added to rainbowkit's official list: https://github.com/rainbow-me/rainbowkit/tree/main/packages/rainbowkit/src/wallets/walletConnectors

Viem already has celo in its chain consts so the need for this package is diminished

@jmrossy
Copy link
Author

jmrossy commented Jan 14, 2024

@aaronmgdr aaronmgdr added the dependencies Pull requests that update a dependency file label Jan 16, 2024
@aaronmgdr
Copy link
Member

alternatively consider deprecating package as (as @jmrossy mentioned) the need for it has diminished and there has proved to be high maintenance costs for such a small config.

@arthurgousset
Copy link
Contributor

Made a Github Discussion about this so we can reference it when making the PR in rainbowkit, if/when we deprecate this package, and for future reference:

@aaronmgdr
Copy link
Member

Ive reached out to Valora and they are keen to add valora config direct to rainbowkit.

for the other wallets terminal and celo wallet othello A confirm they actually work. and if need be make prs to rainbowkit

@jmrossy
Copy link
Author

jmrossy commented Feb 14, 2024

Othello Wallet doesn't support Wallet Connect anymore. It used a beta version of v2 that broke at some point and the lift to migrate it to the latest WC version is surprisingly high. It can be excluded.

@aaronmgdr
Copy link
Member

closing as we will not be create a v2 config but instead ensuring all wallets that still work are in the official repo

@aaronmgdr aaronmgdr closed this as not planned Won't fix, can't repro, duplicate, stale Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

3 participants