Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalisation? #51

Open
spvickers opened this issue Mar 26, 2023 · 4 comments
Open

Internationalisation? #51

spvickers opened this issue Mar 26, 2023 · 4 comments

Comments

@spvickers
Copy link
Contributor

Whilst this library mainly acts as a background connection between two servers, it does return some messages (mainly for errors) which are currently only available in English. Would anyone like to see these being provided in other languages? I would be happy to adapt the library to support this, but would be looking for volunteers to provide translations. Thanks.

@igorbga
Copy link

igorbga commented Apr 15, 2024

To be honest LTI handshake has it's on quirks, issues and complexities and I think that improving the messages themselves trying to give more context so that it is easier to gues what went wrong might be much more valuable than i18n.

That said as I suspect we are not talking about too many messages I would gladly help by translating it to Spanish and Basque.

@spvickers
Copy link
Contributor Author

Thanks for the feedback. Are there any specific examples of where you think the current messages could be improved?

@scollovati
Copy link
Contributor

I'd be more than happy to assist with the translation into Italian.

Regarding the messages themselves, leveraging the locale attribute in the id_token is a good starting point. Additionally, with a change like this, the class parameters reason and details will also need to be adapted to support multiple languages.

@spvickers
Copy link
Contributor Author

Thanks @scollovati, I am in the process of adding more data validation of responses to service requests which is adding new message text to the library, so making its internationalisation more relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants