Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

MSVC version supported #289

Closed
meastp opened this issue Feb 27, 2019 · 6 comments
Closed

MSVC version supported #289

meastp opened this issue Feb 27, 2019 · 6 comments

Comments

@meastp
Copy link
Contributor

meastp commented Feb 27, 2019

The current MSVC version specified is 19, but I don't think that is easy to deduce by everybody. (see https://devblogs.microsoft.com/cppblog/side-by-side-minor-version-msvc-toolsets-in-visual-studio-2017/)

MSVC 2017 has versions x..y.z where x is MSVC 2015, 2017 etc, y is the update number and z is the bugfix/patch-number.

I'm testing on MSVC 2017 15.9.7 (latest update and patch version)

@g-easy
Copy link
Contributor

g-easy commented Feb 28, 2019

Can you tell what Appveyor is using?

@meastp
Copy link
Contributor Author

meastp commented Feb 28, 2019

According to the documentation: https://www.appveyor.com/docs/windows-images-software/#visual-studio-2017 -> 15.9.6.

15.9 is the most important bit - the last is just patch version and these are released quite often.

@g-easy
Copy link
Contributor

g-easy commented Mar 1, 2019

IMO we should specify this (and the travis clang and gcc versions) in the topmost README.md

"Support" so far has been a bit ad-hoc. We merge PRs that improve Windows support (e.g. #283) and also Sturdy and I spent some time trying to generally make things build, but not all of OpenCensus is built and tested on Appveyor yet. PRs welcome. :)

@meastp
Copy link
Contributor Author

meastp commented Mar 1, 2019

Could you specify exactly what's missing for Windows / MSVC support? Perhaps a followup issue with a list of all known missing functionality, like with the cmake followup issue? :)

@g-easy
Copy link
Contributor

g-easy commented Mar 1, 2019

IMO what's missing is "build and test everything on Appveyor." As in blaze test //...

This issue is related to #6

@g-easy
Copy link
Contributor

g-easy commented Mar 20, 2019

Is this issue resolved now that the MSVC version is specified? We still have #6 to track Windows CI.

@meastp meastp closed this as completed Mar 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants