Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

add support for metrics in prometheus exporter #1040

Closed
rghetia opened this issue Mar 1, 2019 · 5 comments
Closed

add support for metrics in prometheus exporter #1040

rghetia opened this issue Mar 1, 2019 · 5 comments

Comments

@rghetia
Copy link
Contributor

rghetia commented Mar 1, 2019

Similar to work done for stackdriver export in metrics.go

@odeke-em
Copy link
Member

odeke-em commented Mar 2, 2019

@rghetia I already did this sometime ago in https://github.com/orijtech/prometheus-go-metrics-exporter and that's what the OpenCensus Agent uses to export to Prometheus.

But really this repo shouldn't depend on Proto but also, I thought we were moving away from using these libraries and moving to the agent?

@rghetia
Copy link
Contributor Author

rghetia commented Mar 4, 2019

@odeke-em that is great that you already have this. Where are all the exporters going to reside? At some point all exporters need to be in one place as oppose to what we have today.

@odeke-em
Copy link
Member

odeke-em commented Mar 4, 2019

Unfortunately I don't know where those exporters are going to reside. The ones I create are under my company's Github account and I write them with a license for the OpenCensus Authors so whenever ready to be moved, it'll be a simple move.

Having said that, I think this issue can be closed. We already have this in https://github.com/census-instrumentation/opencensus-service/tree/master/exporter/prometheusexporter

@rghetia rghetia closed this as completed Mar 4, 2019
@rghetia
Copy link
Contributor Author

rghetia commented Mar 5, 2019

Reopening because we need Prometheus exporter for exporting metrics directly from core-lib without an agent

@rghetia rghetia reopened this Mar 5, 2019
@odeke-em
Copy link
Member

odeke-em commented Mar 5, 2019

The core libraries here though cannot take a dependency on Proto, because if I recall correctly grpc-go uses this code.

I think it is about time for us to extract exporter/prometheus to census-ecosystem/prometheus-go-exporter and then provide perhaps a vanity URL or at least deprecate the exporter in here for contrib.go.opencensus.io/exporter/prometheus (obviously doing a migration to census-ecosystem).

/cc @bogdandrutu @songy23

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants