Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor into monorepo structure #221

Closed
rlrs opened this issue Jan 25, 2024 · 0 comments · Fixed by #230
Closed

Refactor into monorepo structure #221

rlrs opened this issue Jan 25, 2024 · 0 comments · Fixed by #230
Assignees
@rlrs
Labels
no-stale

Comments

@rlrs
Copy link
Collaborator

rlrs commented Jan 25, 2024

As we're beginning to realize that different parts of DFM have different requirements and setups, we should probably separate them a bit more.
It seems cleaner to me to have e.g. lumi-training/scripts than scripts/lumi/training and a bunch of other things inside scripts. Right now, it's also quite confusing what the purpose of the top-level package is. For what reason should I install it?
@rlrs rlrs added the no-stale label Jan 25, 2024
@rlrs rlrs self-assigned this Feb 6, 2024
@rlrs rlrs linked a pull request Feb 6, 2024 that will close this issue
Refactor into monorepo structure #230
Merged
@rlrs rlrs closed this as completed in #230 Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rlrs rlrs

Labels
no-stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor into monorepo structure centre-for-humanities-computing/danish-foundation-models
1 participant
@rlrs