Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create icon component #20

Closed
13 tasks done
Tracked by #19
jholt1 opened this issue Oct 8, 2021 · 0 comments · Fixed by #30
Closed
13 tasks done
Tracked by #19

Create icon component #20

jholt1 opened this issue Oct 8, 2021 · 0 comments · Fixed by #30
Labels
Area: Components Work related to creating or updating components Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: Completed Nothing further to be done with this issue. Awaiting to be closed

Comments

@jholt1
Copy link
Contributor

jholt1 commented Oct 8, 2021 •
edited
Loading

Outcome

To create an icon component that can load SVGs.

Icons are visual symbols that are used to represent objects or actions to reduce cognitive load to a user.

Scope

Properties

  • Type
  • Name
  • Size
  • Describe
  • Category

Tokens

  • Type
  • Name
  • Url
  • Size
  • Fill
  • Category

Directive

SVG-loader

  • Name, Path, Category

Event

  • SVG-loaded

Dev Spec

Minimal usage

<x-icon name="${iconName}"><x-icon>

Shadow Template

	standardTemplate() {
		return html`<div aria-hidden="" role="" aria-label="" class="" styles="">
			${svgLoader(this.name, this.url)}
		</div>`;
	}
@jholt1 jholt1 mentioned this issue Oct 8, 2021
Closed
7 tasks
@jholt1 jholt1 added the Area: Components Work related to creating or updating components label Oct 8, 2021
@jholt1 jholt1 added Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: In Progress This issue is being worked on, and has someone assigned labels Oct 18, 2021
@jholt1 jholt1 linked a pull request Oct 19, 2021 that will close this issue
Feature/icon #30
Merged
@jholt1 jholt1 added Status: Review Needed The issue has a PR attached to it which needs to be reviewed Status: Completed Nothing further to be done with this issue. Awaiting to be closed and removed Status: In Progress This issue is being worked on, and has someone assigned Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Oct 22, 2021
@jholt1 jholt1 added Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. and removed Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. labels Dec 6, 2021
@jholt1 jholt1 closed this as completed Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Components Work related to creating or updating components Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: Completed Nothing further to be done with this issue. Awaiting to be closed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/icon centrica-engineering/muon
1 participant
@jholt1