Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[inputter] Scoped styles #211

Closed
9 tasks done
andij opened this issue Feb 9, 2022 · 3 comments
Closed
9 tasks done

[inputter] Scoped styles #211

andij opened this issue Feb 9, 2022 · 3 comments
Assignees
Labels
Area: Components Work related to creating or updating components Status: Completed Nothing further to be done with this issue. Awaiting to be closed

Comments

@andij
Copy link
Contributor

andij commented Feb 9, 2022

Outcome

Apply the remaining styling to the inputter to meet the design criteria.

Scope

  • The recent introduction of the Light DOM styles #145 has enabled complex CSS selectors to be used.

  • Implement styles for states, attribute selectors, pseudo elements and pseudo classes in inputter for:

    • Text variants (text, email, tel, etc.)
    • search
    • password
    • disabled
    • date
    • mask (Safari font)
    • checkbox
    • radio
@andij andij added the Area: Components Work related to creating or updating components label Feb 9, 2022
@andij andij mentioned this issue Feb 16, 2022
9 tasks
@andij andij self-assigned this Feb 28, 2022
@andij andij added Status: In Progress This issue is being worked on, and has someone assigned Status: Review Needed The issue has a PR attached to it which needs to be reviewed and removed Status: In Progress This issue is being worked on, and has someone assigned labels Feb 28, 2022
@andij
Copy link
Contributor Author

andij commented Mar 3, 2022

@andij andij added Status: In Progress This issue is being worked on, and has someone assigned and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Mar 8, 2022
@andij
Copy link
Contributor Author

andij commented Mar 8, 2022

After further experimentation and discovery we have managed to bring the majority of the styles into the ::slotted() selector.

There are some CSS selectors that are not available to us. This will result in a slightly reduced capability of styling elements in the Light DOM.

@jholt1 and I have discussed this at length and have agreed that any styles within Muon should remain within ::slotted(). And to only style the parts of elements using styles.slotted.css where there is a need to supply browsers that don't yet support the required feature.

For example, this bug within Webkit (Safari): https://bugs.webkit.org/show_bug.cgi?id=223814

The objective is to have no styles.slotted.css if possible.

@andij andij added Status: Completed Nothing further to be done with this issue. Awaiting to be closed and removed Status: In Progress This issue is being worked on, and has someone assigned labels Mar 22, 2022
@andij
Copy link
Contributor Author

andij commented Mar 22, 2022

@andij andij closed this as completed Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Components Work related to creating or updating components Status: Completed Nothing further to be done with this issue. Awaiting to be closed
Projects
None yet
Development

No branches or pull requests

1 participant