Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CFG price history on portfolio tab #2380

Open
hieronx opened this issue Aug 15, 2024 · 2 comments
Open

Fix CFG price history on portfolio tab #2380

hieronx opened this issue Aug 15, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@hieronx
Copy link
Contributor

hieronx commented Aug 15, 2024

Looks like the hosted uniswap v3 subgraph is removed. There is https://thegraph.com/explorer/subgraphs/5zvR82QoaXYFyDEKLZ9t6v9adgnptxYpKpSbxtgVENFV?view=Query&chain=arbitrum-one but that requires an API key. We need to figure out what is the best new data source.

@hieronx hieronx added the bug Something isn't working label Aug 15, 2024
@sophialittlejohn sophialittlejohn self-assigned this Aug 30, 2024
@0x4Graham
Copy link

Image

Just wondering, is it meant to look like this?

@sophialittlejohn
Copy link
Collaborator

In this bug ticket only the CFG price graph that you can see if you click to send DEVEL or CFG was fixed.

Image

But I looked into why the graph you screenshotted is not showing. Turns out we manually disabled it about 3 months ago, I don't know why (maybe because it really doesn't look good in our app). After that we had a ticket to save space for all graphs on the page while they load to prevent jumping on the screen.

Image

So to summarize:
Problem 1: graph was disabled, should we re-enable it?
Problem 2: if the graph is disabled we should NOT save space for the graph (probs best for another bug ticket)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants