Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor eth block handler to follow architectural principles #111

Open
3 tasks
filo87 opened this issue Feb 9, 2024 · 0 comments
Open
3 tasks

Refactor eth block handler to follow architectural principles #111

filo87 opened this issue Feb 9, 2024 · 0 comments

Comments

@filo87
Copy link
Collaborator

filo87 commented Feb 9, 2024

ethHandlers.ts should be refactored to adhere with the following principles:

  • Handlers should contain no direct assignment of Entity values. State alterations must be performed through appropriate Service methods (such as PoolService.ts or LoanService.ts)
  • Avoid use of array iterators methods such as .map() or .foreach() in combination with async functions, as these can lead to the raising of unhandled exceptions. Use for ... of ... instead.
  • Refactor contract calls to be included in the appropriate Service Method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant