Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ‘subvolumegroup’ field in cephfs storageclass #1884

Closed
hookak opened this issue Feb 19, 2021 · 7 comments
Closed

Add ‘subvolumegroup’ field in cephfs storageclass #1884

hookak opened this issue Feb 19, 2021 · 7 comments
Labels
component/cephfs Issues related to CephFS question Further information is requested

Comments

@hookak
Copy link

hookak commented Feb 19, 2021

CephFS has a directory structure like ’/{volume}/{SVG}/{SV}.
Currently, SVG is fixed as csi for all pvc.
e.g., ‘/vol/csi/pvc-1’ , ‘vol/csi/pvc-2’.

I think adding a SVG field in storageclass is necessary.
So the parent directory in which the SV is created could be classified by storageclass.
This makes it easy for multiple MDSs to process metadata in SVG.

I wonder if these features are in the plan.
I'm willing to create a PR for this issue.

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Feb 19, 2021

This is already supported in configmap

"cephFS": {
"subvolumeGroup": "<subvolumegroup for cephfs volumes>"
}

@Madhu-1 Madhu-1 added the question Further information is requested label Feb 19, 2021
@hookak
Copy link
Author

hookak commented Feb 19, 2021

Thanks a lot! That's exactly what I want.
Close issue.

@hookak hookak closed this as completed Feb 19, 2021
@hookak
Copy link
Author

hookak commented Feb 26, 2021

Hi, again.
Changing the default SVG is possible by specifying SVG in the configmap. However, in that case, creating SVs in multiple SVGs is still can not be achieved.

Currently, clusterID and cephFS can be specified in storageclass. Likewise, if a user can specify SVG in storageclass, a SV can be created in the cephfs path that the user wants.

What do you think of this approach? I think this feature to separate the cephfs path by different tenants or services is needed to support QoS.

@hookak hookak reopened this Feb 26, 2021
@Madhu-1
Copy link
Collaborator

Madhu-1 commented Mar 1, 2021

setting the SVG at storageclass is not possible as the storageclass parameters are not sent to the cephcsi In deleteVolume or deleteSnapshot operations. for that the SVG is moved to the configmap. if you want multiple SVG in single cluster you can create configmap like below

[
      {
        "clusterID": "abcd", # this need to be specified in storageclass
        "monitors": [
          "10.20.30.40:6879",
        ],
        "cephFS": {
          "subvolumeGroup": "test"
        }
      },
       {
        "clusterID": "xyz", # this need to be specified in storageclass
        "monitors": [
          "10.20.30.40:6879",
        ],
        "cephFS": {
          "subvolumeGroup": "testing_123"
        }
      },
      {
        "clusterID": "klm", # this need to be specified in storageclass
        "monitors": [
          "10.20.30.40:6879",
        ],
        "cephFS": {
          "subvolumeGroup": "testing_svg"
        }
      }
    ]

@nixpanic nixpanic added the component/cephfs Issues related to CephFS label Mar 1, 2021
@hookak
Copy link
Author

hookak commented Mar 2, 2021

You're right. I thought it a little tricky that pointing the same ceph cluster using a different clusterID in configmap. But I didn't know this detail before.

setting the SVG at storageclass is not possible as the storageclass parameters are not sent to the cephcsi In deleteVolume or deleteSnapshot operations.

Thanks a lot for your comment. I'm gonna update docs for others.

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Mar 15, 2021

closing this one, as its already covered in configmap.

@jpsn123
Copy link

jpsn123 commented May 13, 2021

Thanks a lot for your comment. I'm gonna update docs for others.
@hookak
please quick ^_^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/cephfs Issues related to CephFS question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants