-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase statediffing geth onto v1.10.18 #231
Comments
So the first step is creating the new releases here, the next step will be to work through all the linked issues/repos, find the ones that are next in the dependency tree (aka there is no note in the issue that you will/may also need to update dependency on another repo as well; e.g. ipfs-ethdb, go-eth-state-node-validator, leveldb-ethdb-rpc) and perform those updates and releases, and then move up the dependency tree to repos which depend on the new release of vdb geth + other repos that were updated in the previous step. |
@i-norden - We might want to tackle this ticket as well: #181 I would create a pipeline using the stack orchestrator, similar to: https://github.com/vulcanize/ipld-ethcl-indexer/blob/main/.github/workflows/on-pr.yml#L32 |
I have created two releases:
I tested both by utilizing the stack orchestrator. It was straightforward for To validate I did the following:
|
@i-norden + @ashwinphatak - I have completed all the rebases. Please let me know if you find any errors, issues, or have any thoughts for future releases. @ashwinphatak and his team will do the V3 release for the following repo as there are some complexities between v3 and v4: cerc-io/eth-statediff-fill-service#3 |
1.10.18 has been released, we need to update our custom geth client to work on top of this release.
We need to perform the rebase for both the v3 and v4 versions
git checkout -b v1.10.18-statediff-3.2.1
)git checkout -b v1.10.18-statediff-4.0.1-alpha
)After cutting a release, we will to update the following repos to use these releases:
We will also need to update and release versions of the following repos that use the root v1.10.18 release:
Some changes that necessitate changes in our stack, aside from rebasing our release of this repo and propagating those:
Somethings that potentially warrant further discussion:
eth_getProof
wasn't actually working for storage nodes until this release: core/rawdb: untie freezer and ancient chain data ethereum/go-ethereum#24684The text was updated successfully, but these errors were encountered: