Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window is not defined error from third party libraries #44

Open
jackpilowsky opened this issue Nov 29, 2018 · 3 comments
Open

Window is not defined error from third party libraries #44

jackpilowsky opened this issue Nov 29, 2018 · 3 comments

Comments

@jackpilowsky
Copy link

I have been running into this issue: Misbehaving libraries that are accessing the window object directly. I have been trying workarounds I have found online but CRA keeps throwing errors

@jackpilowsky
Copy link
Author

Ok, I found a workaround that works:

const someMisbehavingLibrary = (isServer ? null : require('misbehaving-library').default);

@jackpilowsky
Copy link
Author

Maybe this should be added to the ReadMe or tutorial. It took me a lot of time of trial and error to find the solution

@cereallarceny cereallarceny mentioned this issue Jun 19, 2019
16 tasks
@cereallarceny
Copy link
Owner

Hey, my apologies for the long wait @jackpilowsky - I'm looking to ensure this is fixed with version 2.0. If you're interested, I could really use your thoughts for what you'd like to see in the upcoming version. Feel free to comment on the issue here with any suggestions. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants