Overmind 19.1.0 throws tree mutation Error on Firefox

[mieky]

It looks like Overmind 19.1.0 (current "latest") gives what I think is a false tree mutation error on Firefox 67.0, but works fine on Safari and Chrome. This issue only seemed to appear in v19.

Loading the "Overmind demo1 - Vue" (https://codesandbox.io/s/k094r7rmyr) throws this error in the console:

Unhandled promise rejection Error: "proxy-state-tree - You are mutating the path "posts", but it is not allowed. The following could have happened:
        
        - You are passing state to a 3rd party tool trying to manipulate the state
        - You are running an asynchronous action from an other action where you forgot to "await" it
        "

If you make actions.getPosts() in overmind.js non-async, the error seems to disappear.

Might be related to #300?

[mieky]

@christianalfoni I would appreciate it if you would be able to confirm this is an actual issue and I'm not imagining things 😊

[christianalfoni]

Hi @mieky and thanks for the example sandbox! I will have a look at this tomorrow morning, extremely weird that it only happens on Firefox. But at least we have a reproducible example, which is a very good start :)

I will let you know tomorrow morning what I figured out!

[christianalfoni]

Okay, I have been checking this. For some reason Firefox is not returning a native promise from async functions. This is extremely weird, as I would expect this to be like a build step thing... but that should have affected all browsers.

I might need to implement some "promise like" thing... but this is so weird, will investigate further

[christianalfoni]

Okay, giving up understanding this... might as well support other Promise implementations as well, so will implement a promise-like check instead

[christianalfoni]

Okay, got help from @FWeinb to find the issue: vuejs/vue-cli#2012 (comment)

Will create a better promise check now

[christianalfoni]

Okay, a new release is on its way. Now it works as expected :) https://codesandbox.io/s/overmind-demo1-vue-k8rjf

[mieky]

Wow, that was fast! Thank you, and kudos for the swift reaction 😊🙌