Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reload issue in ObjectFieldTemplate cards or rethink the implementation #88

Open
miguelgrc opened this issue Sep 30, 2024 · 0 comments
Labels
bug Something isn't working needs refinement Needs to be refined before taking it

Comments

@miguelgrc
Copy link
Collaborator

miguelgrc commented Sep 30, 2024

Adding a condition in ObjectFieldTemplate in https://github.com/cern-sis/react-formule/pull/87/files#diff-d9a9ad1a8e6bdc7615d2d7b24da80bde8774af8abac7921641410b1be3f57ba2R77 causes refresh issues in the cards: they don't immediately refresh when e.g. the title is changed or an item is added inside of a collection, only after performing a subsequent action (i.e. the update is delayed). This also causes some tests to fail.

For now we have left that line unchanged to avoid these issues. We need to investigate how to fix this and make the loading also work. Perhaps the entire logic should be rethought from scratch.

@miguelgrc miguelgrc added bug Something isn't working needs refinement Needs to be refined before taking it labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs refinement Needs to be refined before taking it
Projects
None yet
Development

No branches or pull requests

1 participant