Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Remove region parameter on issuer #205

Open
tdaniely-dn opened this issue Jun 20, 2022 · 2 comments
Open

[Feature Request]: Remove region parameter on issuer #205

tdaniely-dn opened this issue Jun 20, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@tdaniely-dn
Copy link

Describe why this change is needed

The region field on AWSPCA Issuers is redundent and only allows breaking the issuer.

I might have it wrong but it seems that the region must always match the region of the specified PCA arn.
Any region value that is not the region from the PCA arn, will always break.

Therefore it seems that having the parameter at all is a bug, as it's only function is to allow the user to break the issuer.

Describe solutions and alternatives considered (optional)

Controller should derive the API client region from the CA arn itself.

Is there anything else you would like to add?

Thank you for the very usefull tooling!!

@tdaniely-dn tdaniely-dn added the enhancement New feature or request label Jun 20, 2022
@amibhi
Copy link
Contributor

amibhi commented Jun 21, 2022

Thank you for submitting the feature request to AWS Private CA Issue plugin. We will review the request to verify potential usages of the region field and scope out necessary code changes, and get back to you.

@amibhi
Copy link
Contributor

amibhi commented Jun 21, 2022

We reviewed the feature submission, and we agree that there is redundancy as you identified. The region field on AWSPCA Issuers doesn't break core functionality, so we are unable to prioritize implementing this feature at the moment. However, we are happy to review any PRs for this feature, so we will leave this feature request open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants