Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boilerplate checker does not run in CI #68

Open
munnerz opened this issue Sep 17, 2024 · 2 comments
Open

Boilerplate checker does not run in CI #68

munnerz opened this issue Sep 17, 2024 · 2 comments

Comments

@munnerz
Copy link
Member

munnerz commented Sep 17, 2024

When CI runs, the boilerplate checker fails to complete (but does not fail the CI pipeline) due to python missing in the test image, with the message:

/usr/bin/env: 'python': No such file or directory

This means we are not ensuring source files have correct boilerplate/copyright headers.

@munnerz
Copy link
Member Author

munnerz commented Sep 17, 2024

We should also include standard bash headers in https://github.com/cert-manager/csi-lib/blob/main/hack/verify-all.sh (around errexit, nounset etc) so this fails CI in future: https://github.com/cert-manager/csi-lib/blob/main/hack/verify-all.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant