Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cert-manager chart v1.16.0 Schema validation - Issue with global parameters #46

Closed
CeddaerrixGE opened this issue Oct 8, 2024 · 4 comments

Comments

@CeddaerrixGE
Copy link

I have an umbrella chart having cert-manager as a dependency with custom hooks to configure Issuers on post-install/upgrade.
With version v1.16.0, the breaking change about Helm schema validation rejects all the global parameters it does not recognize.

The definition of global (see https://helm.sh/docs/chart_template_guide/subcharts_and_globals/#global-chart-values) is:

Global values are values that can be accessed from any chart or subchart by exactly the same name.

Hence, the helm-tool mentioned under https://cert-manager.io/docs/releases/release-notes/release-notes-1.16/#helm should not reject unknown global and raise an error such as:
image
Instead, it should either ignore the global parameters or just mark them as a warning that they are not recognize by cert-manager.

@CeddaerrixGE
Copy link
Author

After a little research, it seems that using patternproperties would be a way to allow global parameters not required by cert-manager

@ThatsMrTalbot
Copy link
Contributor

With #43 globals no longer sets additionalProperties: false. This was to solve similar issues like cert-manager/cert-manager#7329

This should solve your issue once we release cert-manager 1.16.1

@CeddaerrixGE
Copy link
Author

With #43 globals no longer sets additionalProperties: false. This was to solve similar issues like cert-manager/cert-manager#7329

This should solve your issue once we release cert-manager 1.16.1

Any ETA about cert-manager 1.16.1 release?

@inteon
Copy link
Member

inteon commented Oct 9, 2024

We just released cert-manager v1.16.1.

See https://cert-manager.io/docs/releases/release-notes/release-notes-1.16/#v1161

@inteon inteon closed this as completed Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants