-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom annotations to deployment #211
Comments
In an another issue : cert-manager/cert-manager#4646 (comment) it's mentioned to add in podlabels, but it's showing error realed to Helm. Using v1.12.3 |
No custom labels can be added. Deployment: istio-csr/deploy/charts/istio-csr/templates/deployment.yaml Lines 6 to 7 in d6908d9
Template: istio-csr/deploy/charts/istio-csr/templates/_helpers.tpl Lines 19 to 27 in d6908d9
|
Another use case is adding annotations for prometheus scrape jobs. Now only scraping via service is possible which is not acceptable for everyone |
Add ability to add custom annotations to deployment, e.g.
sidecar.istio.io/inject: "false"
would be valuable if deployed in namespace where sidecar injection is enabled. CSR deployment shouldn't have a sidecar.The text was updated successfully, but these errors were encountered: