Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing underscore in type definition when compiling for w64 #24

Open
jaromil opened this issue Feb 18, 2018 · 2 comments
Open

missing underscore in type definition when compiling for w64 #24

jaromil opened this issue Feb 18, 2018 · 2 comments

Comments

@jaromil
Copy link

jaromil commented Feb 18, 2018

Hi there! thanks for frozen!

this line

frozen/frozen.c

Line 47 in d763609

typedef _int64 int64_t;

should typedef __int64 to correctly compile for win 64bit according to my tests, conducted using mingw32 in cross-compilation to target w64.
@cpq
Copy link
Member

cpq commented Feb 18, 2018

PR please. make sure that the unit test (which uses clang, gcc, VC6 and VC2015) continues to pass.

@jaromil
Copy link
Author

jaromil commented Feb 18, 2018

OK, is there a CI running the tests? I'm unable to run them locally since I don't have VC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaromil @cpq