Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve image upload component #536

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

feat: improve image upload component #536

wants to merge 15 commits into from
+61 −71

Conversation

AfonsoMartins26
Copy link
Contributor

@AfonsoMartins26 AfonsoMartins26 commented Oct 1, 2024 •
edited
Loading

No description provided.

@AfonsoMartins26 AfonsoMartins26 linked an issue Oct 1, 2024 that may be closed by this pull request
Improve image upload component #491
Open
1 task
@AfonsoMartins26 AfonsoMartins26 self-assigned this Oct 1, 2024
@AfonsoMartins26 AfonsoMartins26 marked this pull request as ready for review October 3, 2024 09:59
FilipeR13
FilipeR13 previously approved these changes Oct 3, 2024
View reviewed changes
@AfonsoMartins26 AfonsoMartins26 changed the title feat: Improve image upload component feat: improve image upload component Oct 3, 2024
joaodiaslobo
joaodiaslobo requested changes Oct 3, 2024
View reviewed changes
Copy link
Member

@joaodiaslobo joaodiaslobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also make it so that the component can be used multiple times in a single liveview? 👀

lib/atomic_web/components/image_uploader.ex Outdated Show resolved Hide resolved
@AfonsoMartins26 AfonsoMartins26 marked this pull request as draft October 6, 2024 13:07
@AfonsoMartins26 AfonsoMartins26 marked this pull request as ready for review November 28, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunom27 nunom27 Awaiting requested review from nunom27

@MarioRodrigues10 MarioRodrigues10 Awaiting requested review from MarioRodrigues10

@joaodiaslobo joaodiaslobo Awaiting requested review from joaodiaslobo

@FilipeR13 FilipeR13 Awaiting requested review from FilipeR13

Requested changes must be addressed to merge this pull request.

Assignees

@AfonsoMartins26 AfonsoMartins26

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve image upload component
3 participants
@AfonsoMartins26 @joaodiaslobo @FilipeR13