Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos in Examples H.9 to H.11 -Atmospheric sounding profiles #210

Closed
GeyerB opened this issue Oct 30, 2019 · 3 comments · Fixed by #460
Closed

Typos in Examples H.9 to H.11 -Atmospheric sounding profiles #210

GeyerB opened this issue Oct 30, 2019 · 3 comments · Fixed by #460
Labels
defect Conventions text meaning not as intended, misleading, unclear, has typos, format or language errors

Comments

@GeyerB
Copy link

GeyerB commented Oct 30, 2019

In the examples the temperature is given as

      float temperature(z) ;
          temperature:standard_name = "surface_temperature" ;
          temperature:long_name = "skin temperature" ;
          temperature:units = "Celsius" ;
          temperature:coordinates = "time lon lat z" ;

or

      float temperature(obs) ;
          temperature:standard_name = "surface_temperature" ;
          temperature:long_name = "skin temperature" ;
          temperature:units = "Celsius" ;
          temperature:coordinates = "time lon lat z" ;

As the temperature during the sounding is meant, in all three examples it should be

          temperature:standard_name = "air_temperature" ;
          temperature:long_name = "air temperature" ;

The unit for temperatur (if not K) should be degree_C (given in the standard-name-table column 'Canonical Units').

Additionally in H.11

          profile:cf_name = "profile_id";

is written instead of

          profile:cf_role = "profile_id";
@GeyerB GeyerB added the typo label Oct 30, 2019
@neumannd
Copy link
Contributor

neumannd commented Nov 7, 2019

I would agree with the suggested corrections by @GeyerB (cf_name => cf_role; air_temperature as standard_name; different unit).

@JonathanGregory JonathanGregory added defect Conventions text meaning not as intended, misleading, unclear, has typos, format or language errors and removed typo labels Jul 5, 2023
@JonathanGregory JonathanGregory linked a pull request Sep 26, 2023 that will close this issue
@JonathanGregory
Copy link
Contributor

I have created pull request 460 to make these corrections. Instead of replacing the long_name, I deleted it for simplicity, since it's not mandatory. Thanks for reporting the errors, @GeyerB. Please could someone check and merge. Thanks.

@larsbarring
Copy link
Contributor

Thanks @GeyerB for reporting, and thanks @JonathanGregory for creating the PR, that I have just merged. Small comment: Celsius is in fact a valid alias for degree_celsius, but this does of course not matter for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Conventions text meaning not as intended, misleading, unclear, has typos, format or language errors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants