Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uninstalling obsolete scripts crashes reaper #65

Closed
frenchy64 opened this issue Mar 3, 2023 · 3 comments
Closed

Uninstalling obsolete scripts crashes reaper #65

frenchy64 opened this issue Mar 3, 2023 · 3 comments
Labels
bug

Comments

@frenchy64
Copy link

frenchy64 commented Mar 3, 2023 •
edited
Loading

After synchronizing packages, if I select particular scripts in this window and uninstall them, reaper crashes.

Screenshot 2023-03-03 at 9 45 32 AM

For example, I uninstalled "ReaEQ Tools", then reaper crashes but I can verify the script was successfully uninstalled after restarting reaper. Some other scripts did not crash reaper, but I failed to note them before uninstalling.

Crashed Thread:        0  reaper  Dispatch queue: com.apple.main-thread

Exception Type:        EXC_BAD_ACCESS (SIGSEGV)
Exception Codes:       KERN_INVALID_ADDRESS at 0x0000000000000030
Exception Codes:       0x0000000000000001, 0x0000000000000030

Termination Reason:    Namespace SIGNAL, Code 11 Segmentation fault: 11
Terminating Process:   exc handler [83232]

VM Region Info: 0x30 is not in any region.  Bytes before following region: 140737487294416
      REGION TYPE                    START - END         [ VSIZE] PRT/MAX SHRMOD  REGION DETAIL
      UNUSED SPACE AT START
--->  
      shared memory            7fffffefd000-7fffffefe000 [    4K] r-x/r-x SM=SHM  

Thread 0 Crashed:: reaper Dispatch queue: com.apple.main-thread
0   reaper_reapack-x86_64.dylib   	       0x10a2e463c Dialog::Proc(HWND__*, unsigned int, unsigned long, long) + 236
1   REAPER                        	       0x1025961ac SwellDialogDefaultWindowProc(HWND__*, unsigned int, unsigned long, long) + 444
2   REAPER                        	       0x1025938ae -[REAPERSwell_hwnd tableView:willDisplayCell:forTableColumn:row:] + 302
3   AppKit                        	    0x7ff80d97986e -[NSTableView _delegateWillDisplayCell:forColumn:row:] + 104
4   AppKit                        	    0x7ff80d8be6d3 -[NSTableView preparedCellAtColumn:row:] + 1835
5   AppKit                        	    0x7ff80d8bde9d -[NSTableView _drawContentsAtRow:column:withCellFrame:] + 42
6   AppKit                        	    0x7ff80d8bdb1d -[NSTableView drawRow:clipRect:] + 1638
7   AppKit                        	    0x7ff80d8bd198 -[NSTableView drawRowIndexes:clipRect:] + 707
8   AppKit                        	    0x7ff80d848d09 -[NSTableView drawRect:] + 1670
9   AppKit                        	    0x7ff80d77b194 _NSViewDrawRect + 121
10  AppKit                        	    0x7ff80df603c3 -[NSView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:] + 1810
11  AppKit                        	    0x7ff80d77a8c0 -[NSView(NSLayerKitGlue) _drawViewBackingLayer:inContext:drawingHandler:] + 753
12  QuartzCore                    	    0x7ff811faac9b CABackingStoreUpdate_ + 576
13  QuartzCore                    	    0x7ff81200e3c1 invocation function for block in CA::Layer::display_() + 53
14  QuartzCore                    	    0x7ff811fa9d66 -[CALayer _display] + 2275
15  AppKit                        	    0x7ff80d77a515 -[_NSBackingLayer display] + 462
16  AppKit                        	    0x7ff80d6f24a5 -[_NSViewBackingLayer display] + 554
17  QuartzCore                    	    0x7ff811fa8d08 CA::Layer::display_if_needed(CA::Transaction*) + 900
18  QuartzCore                    	    0x7ff8121226c6 CA::Context::commit_transaction(CA::Transaction*, double, double*) + 648
19  QuartzCore                    	    0x7ff811f89b35 CA::Transaction::commit() + 725
20  AppKit                        	    0x7ff80d8ca64d _NSTryRunModal + 70
21  AppKit                        	    0x7ff80d8ca53d -[NSApplication runModalForWindow:] + 310
22  REAPER                        	       0x10259d71d SWELL_DialogBox(SWELL_DialogResourceIndex*, char const*, HWND__*, long (*)(HWND__*, unsigned int, unsigned long, long), long) + 397
23  reaper_reapack-x86_64.dylib   	       0x10a31375c std::__1::__function::__func<ReaPack::setupTransaction()::$_5, std::__1::allocator<ReaPack::setupTransaction()::$_5>, void ()>::operator()() + 316
24  reaper_reapack-x86_64.dylib   	       0x10a337ccf Transaction::finish() + 2319
25  reaper_reapack-x86_64.dylib   	       0x10a334e0f Transaction::runTasks() + 5455
26  reaper_reapack-x86_64.dylib   	       0x10a3325af std::__1::__function::__func<ThreadPool::push(ThreadTask*)::$_1, std::__1::allocator<ThreadPool::push(ThreadTask*)::$_1>, void ()>::operator()() + 79
27  reaper_reapack-x86_64.dylib   	       0x10a33218f std::__1::__function::__func<AsyncEvent<void ()>::operator()() const::'lambda'(), std::__1::allocator<AsyncEvent<void ()>::operator()() const::'lambda'()>, void ()>::operator()() + 47
28  reaper_reapack-x86_64.dylib   	       0x10a2e7713 AsyncEventImpl::Loop::mainThreadTimer() + 243
29  REAPER                        	       0x1020e83b0 runMiscTimers() + 2720
30  REAPER                        	       0x102156b89 Main_OnTimer(HWND__*, unsigned long) + 329
31  REAPER                        	       0x10272a146 MainProc(HWND__*, unsigned int, unsigned long, long) + 3494
32  REAPER                        	       0x1025961ac SwellDialogDefaultWindowProc(HWND__*, unsigned int, unsigned long, long) + 444
33  Foundation                    	    0x7ff80b377597 __NSFireTimer + 67
34  CoreFoundation                	    0x7ff80a4f6946 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 20
35  CoreFoundation                	    0x7ff80a4f64ae __CFRunLoopDoTimer + 820
36  CoreFoundation                	    0x7ff80a4f60c4 __CFRunLoopDoTimers + 285
37  CoreFoundation                	    0x7ff80a4dca0c __CFRunLoopRun + 2098
38  CoreFoundation                	    0x7ff80a4dbb60 CFRunLoopRunSpecific + 560
39  HIToolbox                     	    0x7ff813e29766 RunCurrentEventLoopInMode + 292
40  HIToolbox                     	    0x7ff813e29576 ReceiveNextEventCommon + 679
41  HIToolbox                     	    0x7ff813e292b3 _BlockUntilNextEventMatchingListInModeWithFilter + 70
42  AppKit                        	    0x7ff80d62c2f3 _DPSNextEvent + 909
43  AppKit                        	    0x7ff80d62b174 -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 1219
44  AppKit                        	    0x7ff80d61d7b7 -[NSApplication run] + 586
45  AppKit                        	    0x7ff80d5f17f7 NSApplicationMain + 817
46  dyld                          	    0x7ff80a0cf310 start + 2432

I also have these errors when I synchronize, in case they're relevant:

MPL Scripts/FX/Toggle bypass FX with latency (PDC) higher than X samples v1.06:
  Conflict: Scripts/MPL Scripts/FX/mpl_Toggle bypass all project FX with latency (PDC) higher than 64 samples.lua is already owned by another package

MPL Scripts/FX/Toggle bypass FX with latency (PDC) higher than X samples v1.06:
  Conflict: Scripts/MPL Scripts/FX/mpl_Toggle bypass all project FX with latency (PDC) higher than 128 samples.lua is already owned by another package

MPL Scripts/FX/Toggle bypass FX with latency (PDC) higher than X samples v1.06:
  Conflict: Scripts/MPL Scripts/FX/mpl_Toggle bypass all project FX with latency (PDC) higher than 256 samples.lua is already owned by another package

MPL Scripts/FX/Toggle bypass FX with latency (PDC) higher than X samples v1.06:
  Conflict: Scripts/MPL Scripts/FX/mpl_Toggle bypass all project FX with latency (PDC) higher than 512 samples.lua is already owned by another package

MPL Scripts/FX/Toggle bypass FX with latency (PDC) higher than X samples v1.06:
  Conflict: Scripts/MPL Scripts/FX/mpl_Toggle bypass all project FX with latency (PDC) higher than 1024 samples.lua is already owned by another package

MPL Scripts/FX/Toggle bypass FX with latency (PDC) higher than X samples v1.06:
  Conflict: Scripts/MPL Scripts/FX/mpl_Toggle bypass all project FX with latency (PDC) higher than 2048 samples.lua is already owned by another package

MPL Scripts/FX/Toggle bypass FX with latency (PDC) higher than X samples v1.06:
  Conflict: Scripts/MPL Scripts/FX/mpl_Toggle bypass all project FX with latency (PDC) higher than 4096 samples.lua is already owned by another package

MPL Scripts/FX/Toggle bypass FX with latency (PDC) higher than X samples v1.06:
  Conflict: Scripts/MPL Scripts/FX/mpl_Toggle bypass all project FX with latency (PDC) higher than 8192 samples.lua is already owned by another package

OS: macOS 13.2.1
Reaper: 6.77
ReaPack v1.2.4.2 daa3346 built on Oct 07 2022 19:02:56
@cfillion
Copy link
Owner

cfillion commented Mar 3, 2023

So far I've seen two other reports of this bug on macOS 13 and 10.14 but never have been able to duplicate it locally (macOS 10.14 on bare-metal and macOS 12 in a VM).

Made a tentative fix (build here) based on the backtrace but haven't received definitive confirmation whether it actually solves it or not from the other affected users. Could you give it a try?

@cfillion cfillion added the bug label Mar 3, 2023
@frenchy64
Copy link
Author

That fixed it, I was able to uninstall all the remaining scripts without a crash.

@cfillion
Copy link
Owner

cfillion commented Mar 3, 2023

Awesome, thanks! In that case I'll ship that patch in a release very soon. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frenchy64 @cfillion