Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runwar resolves full file system paths via the URL #149

Open
bdw429s opened this issue Jan 29, 2019 · 0 comments
Open

Runwar resolves full file system paths via the URL #149

bdw429s opened this issue Jan 29, 2019 · 0 comments

Comments

@bdw429s
Copy link
Member

bdw429s commented Jan 29, 2019

This only affects *nix OS's and will only serve files from the web root, but it potentially exposes the full path to the web root to a user who can guess the path.

http://localhost/Users/brad/Projects/mySite/css/fontawesome.css

That URL above works because the path /Users/brad/Projects/mySite/css/fontawesome.css is a real absolute path on the file system. However, it should not work. The mapped resource manager allows this because it strips off the cfmlDirsFile path from the start and determines that path lives within a content path we're serving files from. That may make sense in some internal uses cases but not from the URL. I'm unclear on whether the getResource() method of a io.undertow.server.handlers.resource.ResourceManager always gets relative paths, or needs to account for absolute paths as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant