142 all filings endpoint #341
Conversation
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
src/sbl_filing_api/routers/filing.py
Outdated
| @@ -58,6 +60,13 @@ async def get_filing(request: Request, response: Response, lei: str, period_code | |||
| response.status_code = status.HTTP_204_NO_CONTENT | |||
|
|
|||
|
|
|||
| @router.get("/filings/{period_code}", response_model=List[FilingDTO]) | |||
There was a problem hiding this comment.
I think the endpoint of /periods/{period_code}/filings might be better, since we already have a /periods prefix, and the rest of the endpoints are /institutions prefix
| @@ -63,6 +63,14 @@ async def get_filing(session: AsyncSession, lei: str, filing_period: str) -> Fil | |||
| return result[0] if result else None | |||
|
|
|||
|
|
|||
| async def get_filings(session: AsyncSession, leis: list[str], filing_period: str) -> list[FilingDAO]: | |||
| stmt = select(FilingDAO).where(FilingDAO.lei.in_(leis)).filter_by(filing_period=filing_period) | |||
There was a problem hiding this comment.
this works, but we can also just do filter with multiple criteria
select(FilingDAO).filter(FilingDAO.lei.in_(leis), FilingDAO.filing_period == filing_period)possible new version of query_helper to help, although I don't think a new query_helper really saves too many key strokes
There was a problem hiding this comment.
query_helper already takes a set of kwargs using filter_by which doesn’t require filter chaining, you can pass any number of filter arguments to it
There was a problem hiding this comment.
if I remember correctly, filter_by has a key = value limitation; in this scenario a where in clause is needed.
Closes #142