Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Security) Integrate recheck for RegExps #1049

Open
meissadia opened this issue Nov 7, 2024 · 1 comment · May be fixed by #1051
Open

(Security) Integrate recheck for RegExps #1049

meissadia opened this issue Nov 7, 2024 · 1 comment · May be fixed by #1051
Assignees

Comments

@meissadia
Copy link
Collaborator

meissadia commented Nov 7, 2024

  • Confirm regexes are safe
  • If not safe, prevent execution
@meissadia meissadia self-assigned this Nov 7, 2024
@meissadia meissadia linked a pull request Nov 7, 2024 that will close this issue
@meissadia
Copy link
Collaborator Author

Tried integrating recheck but found its execution to drastically slow page loading loading times, which would impact user experience.

Also explored only running recheck in local dev environments as a workaround that would still provide us the opportunity to catch vulnerabilities without affecting users.

Ultimately it seemed best to simply refactor and eliminate usage of dynamic regexes in favor of plain String functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant