kernel: work_q: use flags_get() in work_delayable_busy_get_locked().

flit · Christopher Friedt · commit ea6cccf8bbc0 · 2022-07-21T13:47:16.000-04:00
The k_work::flags field is not an atomic_t and would cause
-Wpointer-sign warning on some compilers. This function was the only
one in work.c to use atomic_get() so there is no benefit to atomicity.

Signed-off-by: Chris Reed &lt;chris.reed@arm.com&gt;
diff --git a/kernel/work.c b/kernel/work.c
@@ -829,7 +829,7 @@ void k_work_init_delayable(struct k_work_delayable *dwork,
 
 static inline int work_delayable_busy_get_locked(const struct k_work_delayable *dwork)
 {
-	return atomic_get(&dwork->work.flags) & K_WORK_MASK;
+	return flags_get(&dwork->work.flags) & K_WORK_MASK;
 }
 
 int k_work_delayable_busy_get(const struct k_work_delayable *dwork)

Original file line number	Diff line number	Diff line change
`@@ -829,7 +829,7 @@ void k_work_init_delayable(struct k_work_delayable *dwork,`
`829`	`829`
`830`	`830`	`static inline int work_delayable_busy_get_locked(const struct k_work_delayable *dwork)`
`831`	`831`	`{`
`832`		`- return atomic_get(&dwork->work.flags) & K_WORK_MASK;`
	`832`	`+ return flags_get(&dwork->work.flags) & K_WORK_MASK;`
`833`	`833`	`}`
`834`	`834`
`835`	`835`	`int k_work_delayable_busy_get(const struct k_work_delayable *dwork)`