-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metric <-> imperial conversions? #4
Comments
Hey Daniel, great to meet you! That would be awesome; I'm definitely open to directing some more time and energy to maintaining this project if it were to be distributed in a scenario like that. (In fact, I'll go in and update the dev dependencies now to get rid of GitHub's security warnings.) I think imperial <-> metric conversions would be a great addition that would fit well with the existing API. Would you be willing to kick start the work for that? I'd be more than happy to look over some PRs for that feature. Thanks! |
Sweet :)
Thanks!
Yep, more than happy to. We're not moving on it immediately, so I'll loop back around when we plan to start. |
To share a bit more context, this is from our internal Asana:
We need to do a bit more user research before we know which direction to head on this. |
@danielbachhuber thanks for the additional info, that definitely sheds some light on the issue. It sounds like you're looking to convert between volume (e.g. cups) and mass (e.g. grams). I've run into this issue quite a bit when brewing coffee, for example. The most precise brewing instructions specify a coffee amount in grams, but most people are more familiar with using tablespoons to measure out coffee. It's impossible to directly interconvert between the two, because it depends on the density of that particular coffee. Anyway, I think this can be split up into two separate issues:
By being smart about the densities stored, I think the second item can be accomplished without adding much weight to the library at all. |
Cool :) We'll follow up when we dive into this project. Thanks! |
Great tool @cgatno, keep the good work 👍 . |
Hi! great library, I think both of this use cases present themself frequently with recipes. For the second point maybe a complement like Moment timezone, could store all the transformations density of common ingredient, and some way to add explicit densities would be great. |
👋 I work for WP Tasty and we're thinking about using this library in our plugin, Tasty Recipes.
Have you considered offering imperial -> metric conversions (and back again)? Would you be open to some pull requests for this?
The text was updated successfully, but these errors were encountered: