Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax error in un-used test file #11

Open
MasonProtter opened this issue May 14, 2023 · 3 comments
Open

Syntax error in un-used test file #11

MasonProtter opened this issue May 14, 2023 · 3 comments

Comments

@MasonProtter
Copy link

MasonProtter commented May 14, 2023

Just an FYI, this expression : https://github.com/cgeoga/BesselK.jl/blob/main/paperscripts/testing/notinuse/matern_derivative_speed.jl#L7-L18

doesn't actually do what it seems like! Currently, writing (@foo x, @foo y) is parsed as (@foo(x, @foo(y))), not (@foo(x), @foo(y)) though changing that is currently under consideration in JuliaLang/julia#36547

@cgeoga
Copy link
Owner

cgeoga commented May 14, 2023

Ooh, wow, TIL! Thank you for pointing this out. I suppose I should go through all of those old scripts and make sure that they still run. I could have sworn that that script also ran and did what I thought it was doing at the time, but I suppose it couldn't have.

Appreciate the heads up! I'll avoid that pattern in the future.

@MasonProtter
Copy link
Author

It was discovered by some very cool automated analysis by @c42f over in JuliaSyntax.jl!

@c42f
Copy link

c42f commented May 15, 2023

Thanks @MasonProtter :-)

It's been on my mind to notify everyone using this surprising syntax so that (a) they can use brackets and be less surprised and (b) so that we can later change the meaning of the syntax to the expected meaning without changing anything. Clearly I haven't got around to it yet, so thanks for starting it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants