Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Padding on .template-container causes scroll bars #864

Closed
benjeffery opened this issue Mar 15, 2017 · 1 comment · Fixed by #870
Closed

Padding on .template-container causes scroll bars #864

benjeffery opened this issue Mar 15, 2017 · 1 comment · Fixed by #870
Assignees
@leehart
Labels
bug

Comments

@benjeffery
Copy link
Member

No description provided.

@benjeffery benjeffery added the bug label Mar 15, 2017
@leehart
Copy link
Collaborator

leehart commented Mar 17, 2017 •
edited
Loading

Example:
Ag1000G_Selection > Populations
See that there are unnecessary scrollbars on the Details tab, which contains a span element with class="template-container"

Notes:

  • Template is one of the viewTypes defined in panoptes/DataItemViews.js
  • DataItemViews imports components/Template.js
  • Template imports panoptes/ItemTemplate.js and styles/template.scss and uses className template-container for ItemTemplate

@leehart leehart self-assigned this Mar 17, 2017
@leehart leehart mentioned this issue Mar 17, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leehart leehart

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move template-container padding to item-template class cggh/panoptes
2 participants
@benjeffery @leehart