Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FW PR #2864 Added navigation item management #14

Closed
kirsty-hames opened this issue Aug 5, 2020 · 0 comments · Fixed by #21
Closed

FW PR #2864 Added navigation item management #14

kirsty-hames opened this issue Aug 5, 2020 · 0 comments · Fixed by #21

Comments

@kirsty-hames
Copy link
Contributor

Close will need updating to support PR - adaptlearning/adapt_framework#2864

render_nav_element

Avoid targeting nav items for render e.g. $el.insertAfter($('.js-nav-back-btn')) as this will render elements within the .nav__item containers used to control the navigation layout. With CGKineo navigation plugins we started targeting Drawer or Back button as a way of controlling the dom order but this will no longer be needed. Suggest generic $el.appendTo('.nav__inner') as per contrib plugins like languagePicker.

Nav plugins that aren't updated to support nav item management but are rendered into .nav__inner will just display last inside the nav bar.

render_nav_inner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant