Skip to content

Commit fbd940d

Browse files
committed
Fix mis-scrobbled albums.
Attempt to fix the wrong album being scrobbled by defaulting to `currentTrack.album` instead of the data returned from `track.getInfo`.
1 parent 998715a commit fbd940d

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

src/js/main-background.js

+9-2
Original file line numberDiff line numberDiff line change
@@ -94,15 +94,22 @@ window.scroblrGlobal = (function () {
9494
*/
9595
function getTrackInfoCallback(data) {
9696
var trackParams = {
97-
album: $("track > album title", data).text() || currentTrack.album || "",
98-
image: $("track > album image[size=large]", data).text() || "",
9997
loved: $("track userloved").text() == "1",
10098
url_album: $("track > album url", data).text() || "",
10199
url_artist: $("track > artist url", data).text() || "",
102100
url_track: $("track > url", data).text() || "",
103101
tags: []
104102
};
105103

104+
if (currentTrack.album) {
105+
trackParams.album = currentTrack.album;
106+
// TODO Retrieve album art through API call.
107+
trackParams.image = "";
108+
} else {
109+
trackParams.album = $("track > album title", data).text() || "";
110+
trackParams.image = $("track > album image[size=large]", data).text() || "";
111+
}
112+
106113
if (!currentTrack.duration) {
107114
trackParams.duration = parseFloat($("track > duration", data).text());
108115
}

0 commit comments

Comments
 (0)