-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Precommit removes shebang from executable #3
Comments
imo due to issues like these I think we probably shouldn't implement a license precommit hook ourselves since it already exists. There are a lot of edge cases like this that are easy to miss and a lot of different languages to handle. We also should probably support spdx license identifiers as the standard which is another thing to add. |
My understanding was https://github.com/google/addlicense is not a precommit action. What are you using? |
Would also really like to include who owns the file in the header. |
We will also need the action to work for some internal private license |
I am using the precommit action from the fork that was used for this pr. It was approved today so imagine it will be merged. google/addlicense#160 |
|
Description
Pre-commit action removes the shebangs from an executable shell script when adding the header.
Steps to Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots/Tracebacks
If applicable, add screenshots to help explain your problem.
Environment
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: