Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRLIR: Find a good heuristic to guess window_size and stripe_size #52

Open
RunDevelopment opened this issue Nov 26, 2023 · 3 comments
Open
Labels
enhancement New feature or request

Comments

@RunDevelopment
Copy link
Member

GRLIR's window_size and stripe_size hyperparameters are undetectable, but very important to get the correct model output. When incorrect values are used, the output because unusable. See example here.

Find a way to guess/detect window_size and stripe_size for all official models.

@RunDevelopment RunDevelopment added the enhancement New feature or request label Nov 26, 2023
@zelenooki87
Copy link

zelenooki87 commented Nov 26, 2023

https://github.com/HolyWu/vs-grlir/blob/master/vsgrlir/__init__.py

In holywus repo there are magical numbers.
Do not know if realy working. Please test :)

@zelenooki87
Copy link

zelenooki87 commented Nov 26, 2023

Hey.
You are my hero.
Replaced updated heuristic fix files, everything is OK. Will play with tile settings, cause on some photos there are patches.

One thing, that happens with grlir is sometimes blue circle around humans eye pupil. Alongside that(which was expected in Hybrid VS experienced same) model are realy good, realy does great job on denoising debluring and upscaling.
When I try to eliminate that with codeformer, there is bug.

image image

Thanks for great work.

@RunDevelopment
Copy link
Member Author

Replaced updated heuristic fix files, everything is OK

That's good to hear.

When I try to eliminate that with codeformer, there is bug.

Fixed by chaiNNer-org/chaiNNer#2337.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants