Create CODEOWNERS #1004
Merged
Create CODEOWNERS #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vieiralucas
previously approved these changes
Jul 7, 2017
|
Can't easily see why the build is failing - looks like an IE11 issue. I'll look into it later. |
|
Looks like fails are caused by SameValueZero tests (https://github.com/chaijs/chai/pull/994/files#diff-c7f56e7ef2d6759cc445c937a78f61cfR1725) added in #994. I think we should comment them until we drop IE11. |
|
😞 We really need to figure out a good way to run saucelabs tests in PRs |
meeber
approved these changes
Jul 11, 2017
This was referenced Jul 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to the new Code Owners feature we can now automatically require reviews from individual contributors, or a group of contributors.
This change adds a
CODEOWNERSfile to this repo, saying that all files in the repo are owned by @chaijs/chai - which consists of @logicalparadox, @astorije, @keithamus, @shvaikalesh, @lucasfcosta, @vieiralucas and @meeber. With this file, at least one of those maintainers will need to approve every pull request coming into this repo. The team will pinged for every PR.