eql does not work to compare Nodes in Firefox

[arv]

eql uses Object.keys which only includes enumerable own properties. For DOM Nodes we have no own properties so they end up considered to be equal.

chai.expect(document.createTextNode('a')).to.not.eql(document.createTextNode('b'))

[domenic]

Hmm, definitely an oversight. I'm not sure what the state of the art for deep-equal algorithms is. Any advice on the DOM element case in particular?

[arv]

The main reason I was using eql was to compare two arrays with nodes. For now I just ended up adding arrayEqual but I was told that eql was supposed to cover this use case.

I think there will be more cases like this in the future where people end up using getters on the prototype chain (like the DOM).

[domenic]

@logicalparadox any ideas on how we should modify the deep equal algorithm for this?

As @arv says, there are plenty of objects with getters in their prototype chain for which this might be important.

I believe QUnit.equiv compares DOM nodes in some way. Or maybe it just compares non-own properties, and that's how it catches this.

I guess my initial thought is to just expand our current algorithm to include non-own properties as well.

[logicalparadox]

Agreed, it seems best to start with non-own properties and go from there; see if this satisfies the requirement. If we can avoid implementing different algorithms for different browsers, I think everyone involved would be much happier.