Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert.sameMembers should work for sets #1468

Closed
djmattyg007 opened this issue May 29, 2022 · 0 comments · Fixed by #1583
Closed

assert.sameMembers should work for sets #1468

djmattyg007 opened this issue May 29, 2022 · 0 comments · Fixed by #1583

Comments

@djmattyg007
Copy link

In the mathematical definition of a "set", the contents of a set are known as "members". It therefore stands that an assertion named "same members" should be able to handle sets. I believe this would be significantly more intuitive than using hasAllKeys, because a set does not actually have keys.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set support in same members koddsson/chai
1 participant
@djmattyg007