Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release chai@4.0.0 #972

Merged
merged 1 commit into from
May 26, 2017
Merged

Release chai@4.0.0 #972

merged 1 commit into from
May 26, 2017

Conversation

lucasfcosta
Copy link
Member

Are you ready for this?

I think we have already done all the things we needed for this release.

In this PR I uncommented the lines mentioned by @keithamus at .travis.yml and ran make release-major.

The migration guide is totally up-to-date and the canary versions have been out for quite some time.

Thanks everyone for your contributions, it's awesome to work with such great people.

Celebrate!

@keithamus keithamus merged commit 6349ff4 into chaijs:master May 26, 2017
@keithamus
Copy link
Member

@lucasfcosta it looks as though the lines are still commented, we'll need to uncomment them, and then publish this tag against master.

@keithamus
Copy link
Member

I've uncommented the lines in #973. Once that's merged I can publish the tag against our working release notes, and chai 4.0 can be released today!

@lucasfcosta
Copy link
Member Author

@keithamus thanks!

I thought the make release-major was gonna do this alongside the release commit. Sorry 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants