Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty scenarios should not return a wrong or malformed query #176

Open
tahini opened this issue Aug 25, 2022 · 3 comments
Open

Empty scenarios should not return a wrong or malformed query #176

tahini opened this issue Aug 25, 2022 · 3 comments

Comments

@tahini
Copy link
Collaborator

tahini commented Aug 25, 2022

APIv2 has more possible error messages than v1, which returns a wrong or malformed query for every possible exception.

For the case of empty scenario though, we could return a clearer exception, even in v1 (since v2 is not implemented yet, I have a branch somewhere, but haven't touched it in a while).

@greenscientist
Copy link
Contributor

@tahini , do you mean here if the request has an invalid scenario_id in its parameter or something else ?

@tahini
Copy link
Collaborator Author

tahini commented Nov 27, 2023

By empty scenario, I mean a scenario with no connection in it. For example, in Transition, create a scenario with a service X, then delete the service X. The scenario is still there, but has no service associated. That was the case causing the error here. I'm not sure how it is currently handled in v2.

@greenscientist
Copy link
Contributor

Don't know either, but should be easy to add a unit test that cover this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants