Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Change calculation endpoints from POST to GET #1057

Open
tahini opened this issue Sep 18, 2024 · 0 comments
Open

API: Change calculation endpoints from POST to GET #1057

tahini opened this issue Sep 18, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@tahini
Copy link
Collaborator

tahini commented Sep 18, 2024

These calculations are idempotent requests and do not trigger updates on the server. Therefore they correspond more to the definition of a GET request (see https://www.w3schools.com/tags/ref_httpmethods.asp)

GET also have the advantage to be easier to use and manage.

But in the parameters, we have geojson attributes for the origins and destinations. As get parameters, they should be changed to simply the coordinates of the points instead.

All requests with calculations are affected by this issue. As of today, they are accessibility, route and summary.

While these requests can be added to the current API, the current POST ones should be deprecated and we may want to increment the API version.

@tahini tahini added the good first issue Good for newcomers label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant