Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deck.gl: Better handle disabling clicks with measure tool #1226

Open
tahini opened this issue Jan 31, 2025 · 0 comments
Open

deck.gl: Better handle disabling clicks with measure tool #1226

tahini opened this issue Jan 31, 2025 · 0 comments

Comments

@tahini
Copy link
Collaborator

tahini commented Jan 31, 2025

A simple search of the following code shows a lot of hits in location that should not be aware of the existence of this tool. This is a breach in responsibility principle and modularity. The map or the tool itself should handle the map event deactivation. This should be done and documented in the code before implementing other map level tools like #1224

    if (serviceLocator.selectedObjectsManager.isSelected('measureTool')) {
        return;
    }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant