[MERGE #5775 @akroshg] Fixing out of stack AV in Destructuring pattern.

Merge pull request #5775 from akroshg:fix5773_1 Probe stack first to see if the stack is available.
chakra-core · Oct 22, 2018 · 12cfbd0 · 12cfbd0
2 parents 1f6d785 + 79738fe
commit 12cfbd0
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/lib/Parser/Parse.cpp b/lib/Parser/Parse.cpp
@@ -12874,6 +12874,9 @@ ParseNodePtr Parser::ParseDestructuredLiteral(tokens declarationType,
 {
     ParseNodeUni * pnode = nullptr;
     Assert(IsPossiblePatternStart());
+
+    PROBE_STACK_NO_DISPOSE(m_scriptContext, Js::Constants::MinStackDefault);
+
     if (m_token.tk == tkLCurly)
     {
         pnode = ParseDestructuredObjectLiteral<buildAST>(declarationType, isDecl, topLevel);

diff --git a/test/Bugs/misc_bugs.js b/test/Bugs/misc_bugs.js
@@ -189,6 +189,28 @@ var tests = [
         });
       }
   },
+  {
+    name: "destructuring : testing recursion",
+    body: function () {
+      try {
+        eval(`
+            var ${'['.repeat(6631)}
+          `);
+          assert.fail();
+        }
+        catch (e) {
+        }
+
+        try {
+            eval(`
+               var {${'a:{'.repeat(6631)}
+            `);
+            assert.fail();
+        }
+        catch (e) {
+        }
+      }
+  }
 
 ];