Skip to content

Commit

Permalink
[MERGE #5659 @rhuanjl] Fix a couple of typos in Jsrt Header comments
Browse files Browse the repository at this point in the history
Merge pull request #5659 from rhuanjl:updateHeaders

This PR fixes a few typos I noticed in the Jsrt Header comments as well as one pointed out by @RealTrisT in #5615
  • Loading branch information
dilijev committed Sep 4, 2018
2 parents 705338b + 63ca567 commit 4d82238
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
7 changes: 4 additions & 3 deletions lib/Jsrt/ChakraCommon.h
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ typedef unsigned short uint16_t;
/// </summary>
JsErrorInvalidContext,
/// <summary>
/// Module evaluation is called in wrong context.
/// The Module HostInfoKind provided was invalid.
/// </summary>
JsInvalidModuleHostInfoKind,
/// <summary>
Expand All @@ -237,6 +237,7 @@ typedef unsigned short uint16_t;
/// Module was not yet evaluated when JsGetModuleNamespace was called.
/// </summary>
JsErrorModuleNotEvaluated,

/// <summary>
/// Category of errors that relates to errors occurring within the engine itself.
/// </summary>
Expand Down Expand Up @@ -922,7 +923,7 @@ typedef unsigned short uint16_t;
/// <remarks>
/// Removes a reference to a <c>JsRef</c> handle that was created by <c>JsAddRef</c>.
/// </remarks>
/// <param name="ref">The object to add a reference to.</param>
/// <param name="ref">The object to remove the reference from.</param>
/// <param name="count">The object's new reference count (can pass in null).</param>
/// <returns>
/// The code <c>JsNoError</c> if the operation succeeded, a failure code otherwise.
Expand Down Expand Up @@ -1051,7 +1052,7 @@ typedef unsigned short uint16_t;
_Out_ JsRuntimeHandle *runtime);

/// <summary>
/// Tells the runtime to do any idle processing it need to do.
/// Tells the runtime to do any idle processing it needs to do.
/// </summary>
/// <remarks>
/// <para>
Expand Down
2 changes: 1 addition & 1 deletion lib/Jsrt/ChakraCore.h
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ typedef JsErrorCode(CHAKRA_CALLBACK * FetchImportedModuleCallBack)(_In_ JsModule
/// User implemented callback to fetch imported modules dynamically in scripts.
/// </summary>
/// <remarks>
/// The callback is invoked on the current runtime execution thread, therefore execution is blocked untill
/// The callback is invoked on the current runtime execution thread, therefore execution is blocked until
/// the callback completes. Notify the host to fetch the dependent module. This is used for the dynamic
/// import() syntax.
///
Expand Down

0 comments on commit 4d82238

Please sign in to comment.