Fix some build errors on Linux.

Author: dilijev

lib/Runtime/Base/WindowsGlobalizationAdapter.h

@@ -145,7 +145,7 @@ namespace Js
             return unicodeStatics;
         }
 #endif
-#ifdef ENABLE_INTL_OBJECT 
+#ifdef ENABLE_INTL_OBJECT
     private:
         HRESULT CreateTimeZoneOnCalendar(_In_ DelayLoadWindowsGlobalization *library, __out Windows::Globalization::ITimeZoneOnCalendar**  result);
         static HRESULT VerifyResult(HSTRING * result, HRESULT errCode);
@@ -200,8 +200,11 @@ namespace Js
                 // Here we use Cleanup() because we can't rely on delete (not dealing with virtual destructors).
                 // The template thus requires that the type implement the Cleanup function.
                 instance->Cleanup(); // e.g. deletes the object held in the IPlatformAgnosticResource
-                delete instance; // deletes the instance itself
-                instance = nullptr;
+
+                // REVIEW (doilij): Is cleanup in this way necessary or are the trivial destructors enough, assuming Cleanup() has been called?
+                // Note: delete here introduces a build break on Linux complaining of non-virtual dtor
+                // delete instance; // deletes the instance itself
+                // instance = nullptr;
             }
         }
 

lib/Runtime/Library/IntlEngineInterfaceExtensionObject.cpp

@@ -871,7 +871,9 @@ namespace Js
         }
 
         Assert(numberFormatter);
-        PlatformAgnostic::Resource::AutoPtr<PlatformAgnostic::Resource::IPlatformAgnosticResource> numberFormatterGuard(numberFormatter);
+        // REVIEW (doilij): AutoPtr will call delete on IPlatformAgnosticResource and complain of non-virtual dtor. There are no IfFailThrowHr so is this still necessary?
+        // TODO (doilij): If necessary, introduce an PlatformAgnosticResourceAutoPtr that calls Cleanup() instead of delete on the pointer.
+        // PlatformAgnostic::Resource::AutoPtr<PlatformAgnostic::Resource::IPlatformAgnosticResource> numberFormatterGuard(numberFormatter);
 
         // TODO (doilij): Render signed zero.
 
@@ -937,7 +939,7 @@ namespace Js
         options->SetInternalProperty(Js::InternalPropertyIds::HiddenObject, autoObject, Js::PropertyOperationFlags::PropertyOperation_None, NULL);
 
         // clear the pointer so it is not freed when numberFormatterGuard goes out of scope
-        numberFormatterGuard.setPointer(nullptr);
+        // numberFormatterGuard.setPointer(nullptr);
 
         return scriptContext->GetLibrary()->GetUndefined();
 #else

lib/Runtime/PlatformAgnostic/IPlatformAgnosticResource.h

@@ -26,7 +26,11 @@ namespace Resource
         AutoPtr(const T *ptr) : pointer(ptr) {}
         ~AutoPtr()
         {
-            delete pointer;
+            if (pointer != nullptr)
+            {
+                delete pointer;
+                pointer = nullptr;
+            }
         }
 
         void setPointer(const T *ptr)

lib/Runtime/PlatformAgnostic/Platform/Common/Intl.cpp

@@ -11,6 +11,12 @@
 typedef int16_t int16;
 typedef int32_t int32;
 typedef int64_t int64;
+
+/*
+using uint16 = unsigned int16_t;
+using uint32 = unsigned int32;
+using uint64 = unsigned int64;
+*/
 #include "Codex/Utf8Codex.h"
 
 #ifndef _WIN32